Template talk:POTD default

Sorry

Accidently screwed up the template by pasting a modified code into the wiki entry. It was for use with another site. All apologies. ~Rodney — Preceding unsigned comment added by 99.16.68.198 (talk • contribs)

Template-protected edit request on 6 May 2020

Please change the line beginning |[[File: to the following:

|{{#if:{{{image2|}}}|<div>}}[[File:{{{image1|{{{image|No-image.svg}}}}}}|{{{size|350}}}px{{#if:{{{thumbtime1|{{{thumbtime|}}}}}}|{{!}}thumbtime={{{thumbtime1|{{{thumbtime}}}}}}}}|{{{alt1|{{{alttext|{{{texttitle}}}}}}}}}{{#if:{{{imagelink1|{{{imagelink|}}}}}}|{{!}}link=File:{{{imagelink1|{{{imagelink|}}}}}}|}}]]{{#if:{{{image2|}}}|</div><div style="margin-top:0.5em;">[[File:{{{image2|No-image.svg}}}|{{{size|350}}}px{{#if:{{{thumbtime2|}}}|{{!}}thumbtime={{{thumbtime2}}}}}|{{{alt2}}}{{#if:{{{imagelink2|}}}|{{!}}link=File:{{{imagelink2}}}|}}]]</div>}}

This will allow the display of POTDs with dual images, such as May 6, 2020. Further discussion relating to this request can be found at WT:POTD. — RAVENPVFF · talk · 17:31, 6 May 2020 (UTC)

Ravenpuff, the "if" for parameter |size= looks like a bug: {{#if:{{{size|350}}}|{{{size|350}}}|{{{size|350}}}}}px. —⁠andrybak (talk) 18:42, 6 May 2020 (UTC)

Yes, let's have a sandbox and some testcases please before we start tinkering with code on the main page — Martin (MSGJ · talk) 22:05, 6 May 2020 (UTC)

@MSGJ: This is already in the sandbox. * Pppery * _{it has begun...} 22:12, 6 May 2020 (UTC)

I have matched the |size= handling for the two images in the sandbox. I am concerned that support for |alttext= seems to have gone away in the sandbox, silently replaced by |alt1=. Is that intentional? What happens to existing POTDs that use |alttext=? – Jonesey95 (talk) 23:42, 6 May 2020 (UTC)

@MSGJ and Jonesey95: This isn't actually on the Main Page; that's substed from {{POTD row}}. I've readded |alttext= to the above request. — RAVENPVFF · talk · 02:06, 7 May 2020 (UTC)

@Ravenpuff: {{POTD}} is currently unprotected. Even if it's used to generate templates for the main page rather than going on the main page itself, shouldn't it still have some level above nothing? {{u|Sdkb}} ^talk 03:09, 7 May 2020 (UTC)

@Sdkb: Assuming that you're talking about {{POTD row}}, protection wouldn't be unwelcome, but it's worth noting that the "protected version" (e.g. Template:POTD protected/YYYY-MM-DD) is created by AnomieBOT 26 hours before the scheduled date and only 2 hours before protection is automatically applied, so this gives us time to catch any vandalism or otherwise unexpected output that happens to sneak through. In any case, I don't believe that there's ever been any such issues to date. — RAVENPVFF · talk · 18:26, 7 May 2020 (UTC)

Ravenpuff, please edit the sandbox with your proposed change so that template editors can see whether it is working on the testcases page and can do a proper diff with the live template. You might want to add more test cases to show that all of these new parameters really work. – Jonesey95 (talk) 03:36, 7 May 2020 (UTC)

@Jonesey95: The sandbox had already been edited with the proposed change beforehand. I've added another testcase to verify |image1=, |image2=, |alt1=, |alt2=, |imagelink1= and |imagelink2=. The alt parameters can be checked by hovering over the images to bring up the tooltip, whereas the imagelink parameters can be checked by clicking on the images themselves. I can't find a suitable previous POTD to adapt to test out |thumbtime1= and |thumbtime2=, but I may add an ad hoc testcase for that later. — RAVENPVFF · talk · 18:26, 7 May 2020 (UTC)

Please can you address Jonesey's query on the removed alttext parameter? — Martin (MSGJ · talk) 20:00, 10 May 2020 (UTC)

Sorry, I've re-added |alttext= to the sandbox. The parameter should work as before. — RAVENPVFF · talk · 11:19, 11 May 2020 (UTC)

@Jonesey95: this is probably ready to go now, unless you have other concerns — Martin (MSGJ · talk) 12:34, 11 May 2020 (UTC)

 Done. I have updated the live template based on the sandbox code. I am wary that this change will cause Linter bogus image options errors. If I see some that appear to be caused by this change, I'll come back here to see if I can fix them. – Jonesey95 (talk) 18:10, 11 May 2020 (UTC)

Tall images broken

It appears that |tall=yes is broken at the moment: Template:POTD default/testcases § Tall picture. I've stumbled upon this while investigating for Template talk:POTD row § Rebuild. —⁠andrybak (talk) 15:42, 27 May 2020 (UTC)

 Fixed in Special:Diff/988982681. —⁠andrybak (talk) 11:05, 16 November 2020 (UTC)