Template talk:Nsdnld

Latest comment: 14 years ago by Dabomb87 in topic Code Update 2

Code Update

edit

{{editprotected}}

Could a templatey administrator change this

<includeonly>{{subst:</includeonly><includeonly>empty template|<strong class="error">You forgot to subst this template. Replace {{nsdnld}} with {{subst:nsdnld}}</strong>}}{</includeonly><noinclude>{</noinclude>{<noinclude>[[Template:</noinclude>di-no source no license<noinclude>|di-no source no license]]</noinclude>|month={{<includeonly>subst:</includeonly>CURRENTMONTHNAME}}|day={{<includeonly>subst:</includeonly>CURRENTDAY}}|year={{<includeonly>subst:</includeonly>CURRENTYEAR}}}}<noinclude>{{pp-template|small=yes}}{{documentation}}</noinclude>

to this

<includeonly>{{{{{|safesubst:}}}substchecktop|Nsdnld|subst={{{subst|}}}}}</includeonly>{{<noinclude>tlp|</noinclude>di-no source no license|<noinclude>2=</noinclude>day={{{{{|safesubst:}}}CURRENTDAY}}|<noinclude>3=</noinclude>month={{{{{|safesubst:}}}CURRENTMONTHNAME}}|<noinclude>4=</noinclude>year={{{{{|safesubst:}}}CURRENTYEAR}}}}<includeonly>{{{{{|safesubst:}}}substcheckbottom|subst={{{subst|}}}}}</includeonly><noinclude>{{Documentation}}</noinclude>

at Template:Nsdnld? Thanks. Set Sail For The Seven Seas 18° 3' 45" NET 01:12, 13 September 2010 (UTC)Reply

  Not done at present. Has this been tested in a sandbox? Also, what does the change do? If it merely simplifies the code, my inclination is "If it ain't broke, don't fix it." —  Tivedshambo  (t/c) 21:50, 21 September 2010 (UTC)Reply

A copy of this code can now be found in the sandbox and its effects can be seen at testcases. The template updates include the following changes:

  1. Updating the substitution check code to a more efficient version.
  2. Updating the date parameters to use existing date templates rather than variables, simplifying the code.
  3. Optimising the demo display on the Template:Nsdnld page to use Template:Tlp, simplifying the code.
  4. Removing the redundant page protection template, which is already included as part of the documentation.
  5. Moving categories to the documentation subpage.

Thanks. Set Sail For The Seven Seas 344° 17' 45" NET 22:57, 21 September 2010 (UTC)Reply

  Done — Martin (MSGJ · talk) 11:06, 22 September 2010 (UTC)Reply

Code Update 2

edit

{{editprotected}} Could a templatey administrator copy over the code at Template:Nsdnld/sandbox to Template:Nsdnld? This will update the date parameters to use existing date templates rather than variables. Thanks. Set Sail For The Seven Seas 203° 31' 30" NET 13:34, 23 September 2010 (UTC)Reply

  Done Dabomb87 (talk) 04:35, 25 September 2010 (UTC)Reply